Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config update for project-factory #1207

Merged
merged 13 commits into from
Aug 1, 2024
Merged

Config update for project-factory #1207

merged 13 commits into from
Aug 1, 2024

Conversation

nitish-egov
Copy link
Contributor

No description provided.

@nitish-egov
updated readmeconfig for sheet
5382443
@nitish-egov
Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…
e461881 
…tend into campaign
@nitish-egov
added cache for generating target template when only delivery conditi…
daa9e0f 
…ons change
@nitish-egov
Merge remote-tracking branch 'origin/campaign' into campaign
287698d
@nitish-egov
Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…
eb434c3 
…tend into campaign
@nitish-egov
Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…
e2df972 
…tend into campaign
@nitish-egov
added logic for having only 18 target columns if exceed i will create…
728ff98 
… one column with header OTHER_TARGETS
@nitish-egov
Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…
35acb0e 
…tend into campaign
@nitish-egov
Merge remote-tracking branch 'origin/campaign' into campaign
591827a
@nitish-egov
updated config to fetch from devops accordingly
62d84e1
@nitish-egov
Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…
7038e59 
…tend into campaign
@nitish-egov
Merge remote-tracking branch 'origin/campaign' into campaign
120709f
@nitish-egov
updated config for project -factory
5486dee
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes improve the handling of boolean configuration settings in the index.ts file. By explicitly evaluating environment variables as strings, the modifications enhance the clarity and reliability of the configuration logic. This prevents unintended truthy evaluations, ensuring that the application's behavior aligns accurately with the specified environment configurations.

Changes

Files Change Summary
utilities/project-factory/src/server/config/index.ts Enhanced boolean evaluation of configuration settings by checking environment variables explicitly for "true". Improved reliability and clarity in the configuration logic.

Poem

🐇 In the code where settings play,
A rabbit hops, no need to stray.
With true and false now clear as day,
The bugs retreat, the code's at bay!
Hooray for fixes, oh what a cheer,
Our configurations now hold dear! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 39b03e6 and 5486dee.

Files selected for processing (1)
  • utilities/project-factory/src/server/config/index.ts (1 hunks)
Additional comments not posted (3)
utilities/project-factory/src/server/config/index.ts (3)

21-21: LGTM! Explicit boolean evaluation improves clarity.

The change ensures that the environment variable IS_CALL_GENERATE_WHEN_DELIVERY_CONDITIONS_DIFFER is strictly evaluated as a boolean value, preventing unintended truthy evaluations.

23-23: LGTM! Explicit boolean evaluation improves clarity.

The change ensures that the environment variable EXCLUDE_HIERARCHY_TYPE_FROM_BOUNDARY_CODES is strictly evaluated as a boolean value, preventing unintended truthy evaluations.

24-24: LGTM! Explicit boolean evaluation improves clarity.

The change ensures that the environment variable EXCLUDE_BOUNDARY_NAME_AT_LAST_FROM_BOUNDARY_CODES is strictly evaluated as a boolean value, preventing unintended truthy evaluations.

@jagankumar-egov jagankumar-egov merged commit 8907a1b into campaign Aug 1, 2024
3 of 4 checks passed
@jagankumar-egov jagankumar-egov deleted the config-update branch August 1, 2024 10:31
Bhavya-egov pushed a commit that referenced this pull request Aug 12, 2024
@nitish-egov @Bhavya-egov
Config update for project-factory (#1207)
501a7e9 
* updated readmeconfig for sheet

* added cache for generating target template when only delivery conditions change

* added logic for having only 18 target columns  if exceed i will create one column with  header OTHER_TARGETS

* updated config to fetch from devops accordingly

* updated config for project -factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-egov ashish-egov ashish-egov approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@jagankumar-egov jagankumar-egov jagankumar-egov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitish-egov @jagankumar-egov @ashish-egov